Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
5838074 to
b1eadef
Compare
|
Superseded by #231 (Contracts, verification infrastructure and resource limits) in the consolidated eight-PR stack for #162. The replacement preserves this PR's code and subsequent fixes; its description links the original head and review discussions. The only additional consolidation fix is the CI-discovered listener cancellation regression, documented on the replacement. All eight replacements have passed their required CI checks. Closing without merging. This branch and its discussions remain available for reference. Review index: #162 (comment) |
1 participant
Define the typed torrent inspection boundary in
library:api, including capability negotiation, bounded task summaries, completion generations, and revision ordering. A delayed response cannot replace a newer same-epoch state; delta gaps and backend epoch changes require resynchronization. Unknown protocol major versions disable known controls.Stack: based on #163 (
torrent-v2-01-foundation). Review this PR against that branch. This is the contract slice of roadmap #162 step 01; implementation continues in focused dependent PRs.KetchApi.torrentsdefaults to null, preserving existing implementations and legacy torrent downloads. The protocol document defines mutation/idempotency, pagination, reconnect, migration, and seed lifecycle semantics. Runtime adapters and typed mutations ship with their implementation slices; this PR advertises no runtime capabilities and does not claim those gates are complete.Validation: API tests pass on JVM and JavaScript, including malformed wire values, unknown capabilities/versions, stale snapshots, delta gaps, epoch changes, and selected-byte completion bounds. Existing core and remote JVM implementations compile. Resource profiles, deterministic harness, and performance baseline remain pending in step 01.