Skip to content

Torrent v2 8/8: V2 engine lifecycle, rate controls and restart recovery - #238

Merged
linroid merged 1 commit into
torrent-v2-stack-07-trackersfrom
torrent-v2-stack-08-runtime
Sep 20, 2026
Merged

linroid merged 1 commit into
torrent-v2-stack-07-trackersfrom
torrent-v2-stack-08-runtime

Conversation

@linroid

@linroid linroid commented Sep 20, 2026 •

Copy link
Copy Markdown
Owner

Owns v2 sessions under shared engine registration, admission and joined shutdown. Includes previously unpublished global/task request rate controls and ownership-validated checkpoint restoration; restored hints never bypass payload rechecking. Incoming v2 routes, automatic checkpoint saving, bounded checkpoint decoding, public source integration and seeding remain incomplete.

Part 8/8 of the consolidated stack for #162. Review and merge bottom-up. This PR targets torrent-v2-stack-07-trackers; its diff contains only this capability group.

Preservation and validation

Consolidates #227–#228. The consolidation snapshot matches original boundary b55c4816 exactly. Fresh CI then exposed a listener shutdown race: canceled accept() could escape as a socket exception. Foundation commit 2fdddd39 fixes cancellation classification and adds a deterministic regression test. This inherited fix and its test are the only file differences from that original boundary; all other contents are preserved. Original branches and discussions are retained.

Includes local commits 86f59382 and b55c4816 beyond #228. That exact source tree passed 619 JVM tests, 599 executed iOS simulator tests and the native-runtime guard. Independent-client conformance was not rerun locally for this recovery addition.

Fresh CI runs on this replacement PR; historical checks and approvals are not transferred. The remaining production roadmap and release gates are still open.

Original PRs and frozen heads

PR Original head
#227 — Own v2 downloads through joined pause and resume lifecycles d72fce51
#228 — Run v2 downloads under shared engine ownership and admission 8b6b1c1f

Review carry-forward

These original discussions and their responses remain linked for review. Their unresolved status is preserved; consolidation does not imply reviewer approval.

Consolidated stack

  1. Torrent v2 1/8: Contracts, verification infrastructure and resource limits #231 — Contracts, verification infrastructure and resource limits
  2. Torrent v2 2/8: V2 identity, metainfo and Merkle integrity #232 — V2 identity, metainfo and Merkle integrity
  3. Torrent v2 3/8: V2 layout and verified storage #233 — V2 layout and verified storage
  4. Torrent v2 4/8: V2 catalog, checkpoints and crash recovery #234 — V2 catalog, checkpoints and crash recovery
  5. Torrent v2 5/8: V2 handshake, hash exchange and bounded transport #235 — V2 handshake, hash exchange and bounded transport
  6. Torrent v2 6/8: V2 scheduling and download execution #236 — V2 scheduling and download execution
  7. Torrent v2 7/8: Tracker lifecycle, editing and discovery privacy #237 — Tracker lifecycle, editing and discovery privacy
  8. Torrent v2 8/8: V2 engine lifecycle, rate controls and restart recovery #238 — V2 engine lifecycle, rate controls and restart recovery

Final consolidated head 74bd4bb0, including the listener shutdown fix, passed 620 JVM tests, 600 executed iOS simulator tests and verifyNoNativeTorrentRuntime locally. Fresh GitHub CI covers the remaining configured platforms and independent-client conformance.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-20T07:45:55.180240Z 6c77951 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Consolidates #227–#228, preserving source b55c481.
Includes the foundation listener cancellation regression fix discovered by consolidation CI.
@github-actions

Copy link
Copy Markdown
Contributor

Test Results

  782 files    782 suites   4m 51s ⏱️
3 242 tests 3 242 ✅ 0 💤 0 ❌
4 482 runs  4 482 ✅ 0 💤 0 ❌

Results for commit 74bd4bb.

@linroid
linroid added this pull request to stack #239 September 20, 2026 08:46
@linroid
linroid merged commit b14ee40 into main Sep 20, 2026
10 checks passed
@linroid
linroid deleted the torrent-v2-stack-08-runtime branch September 20, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant