Fix #4121: No weapon switching when next and previous weapon are bound to the same key - #5375
Merged
Merged
Conversation
FileEX
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Binding the same key to both
next weapon&previous weaponno longer switches the weaponMotivation
Both controls were sent to the game in the same frame, so it cycled a weapon forwards and backwards at once and glitched the switch. they r now cancelled out: when both are down, neither is reported, so the current weapon stays
Closes #4121.
Test plan
Bind
Qto both Next weapon and Previous weapon, then pressQin game; the weapon should not change; unbind Previous weapon:Qshould cycle to the next weapon againChecklist