Repository navigation
[18-stable] Remove unhelpful labelDrops in scrapeConfig - #1112
Conversation
This was reported informally as a bug agaisnt this example alert: https://github.com/openstack-k8s-operators/telemetry-operator/blob/main/docs/sample-alerts/openstack-observability-services-status.yaml#L23 User states that Pod label doesn't exist. This labelDrop configuration dates back to STF, when none of the OSP17 services ran in OCP. These labels were meaningless/misleading at the time, always reflecting values of the smart-gateway rather than the actual services in question (nothing in the OSP17 control-plane ran in a "pod" or "namespace", and the "job" was always the same). I've opted to continue to drop "publisher", concurring with Juan's opinion on the matter. I've checked it and says "ceilometer" on 171 series in my environment, and "ceilometer-0" on 1 series. That's a question I'm not going to tackle right now, but the label doesn't seem terribly useful, so we'll continue to drop it.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
/cherry-pick 18.0-fr7 |
|
@vyzigold: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, vyzigold The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6910c32
into
openstack-k8s-operators:18-stable
|
@vyzigold: new pull request created: #1113 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #1011
/assign vyzigold