Repository navigation
[18.0-fr7] Remove unhelpful labelDrops in scrapeConfig - #1113
Conversation
This was reported informally as a bug agaisnt this example alert: https://github.com/openstack-k8s-operators/telemetry-operator/blob/main/docs/sample-alerts/openstack-observability-services-status.yaml#L23 User states that Pod label doesn't exist. This labelDrop configuration dates back to STF, when none of the OSP17 services ran in OCP. These labels were meaningless/misleading at the time, always reflecting values of the smart-gateway rather than the actual services in question (nothing in the OSP17 control-plane ran in a "pod" or "namespace", and the "job" was always the same). I've opted to continue to drop "publisher", concurring with Juan's opinion on the matter. I've checked it and says "ceilometer" on 171 series in my environment, and "ceilometer-0" on 1 series. That's a question I'm not going to tackle right now, but the label doesn't seem terribly useful, so we'll continue to drop it.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Build failed (check pipeline). Post ❌ telemetry-openstack-meta-content-provider-master FAILURE in 25m 58s Warning: |
|
recheck |
|
Build failed (check pipeline). Post ✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 2h 39m 15s Warning: |
|
recheck |
|
Build failed (check pipeline). Post ✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 2h 45m 01s Warning: |
|
recheck with depends on |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, vyzigold The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post ✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 2h 44m 19s Warning: |
|
I'll override, because all the zuul jobs passed in different buildsets. The latest buildset just failed on a single CK tempest test, which is flakey across all PRs. |
|
/override rdoproject.org/github-check |
|
@vyzigold: Overrode contexts on behalf of vyzigold: rdoproject.org/github-check DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1849c67
into
openstack-k8s-operators:18.0-fr7
This is an automated cherry-pick of #1112
Depends-On: infrawatch/feature-verification-tests#481
/assign vyzigold