Skip to content

docs: drop nimja 0.10.3 workaround, fixed in nimja 0.11.0 - #266

Merged
pietroppeter merged 2 commits into
mainfrom
claude/remove-nimja-workaround
Nov 8, 2026
Merged

pietroppeter merged 2 commits into
mainfrom
claude/remove-nimja-workaround

Conversation

@pietroppeter

Copy link
Copy Markdown
Owner

Requested by Pietro · project thread

Before: nimble docsdeps installs nimja 0.10.3 and deletes the nimja 0.10.4 package directory, because 0.10.4 did not compile to js (enthus1ast/nimja#118). This was the workaround added in #261.

After: docsdeps is back to its original install line, and happyx pulls the latest nimja. nimja 0.11.0 (2026-10-29) fixes #118 by guarding copyMem with when defined(js) or defined(nimscript).

How: revert the docsdeps part of #261 in nimib.nimble. The ubuntu-24.04 pin from #261 stays.


Generated by Claude Code

enthus1ast/nimja#118 is fixed in nimja 0.11.0, which happyx now pulls in.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014vxU9L8TCDMCxwvSH5LKR8

Copy link
Copy Markdown
Owner Author

Checked that the nimja fix is really released and that this PR's CI used it:

  • nimja tag 0.11.0 exists upstream (commit 88652b8), and its nimja.nimble reads version = "0.11.0". In that tag, src/nimja/nimjautils.nim guards copyMem with when defined(js) or defined(nimscript), which is the fix for guard copyMem for js enthus1ast/nimja#118.
  • The docs build log for this PR shows Downloading https://github.com/enthus1ast/nimja (0.11.0) using git, followed by [nimib.saving file: ] ./interactivity.html. That is the page that failed with copyMem on 0.10.4, so the job really built it with 0.11.0.

All checks are green, so this is ready to merge.


Generated by Claude Code

Makes the minimum nimja version explicit, so docsdeps never resolves
to 0.10.4, which does not compile to js (enthus1ast/nimja#118).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YPMoamS3J47kGd4SUSKiTX
@pietroppeter
pietroppeter merged commit 4469474 into main Nov 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple nbCodeToJsInit can't be interlaced

2 participants