Repository navigation
docs: drop nimja 0.10.3 workaround, fixed in nimja 0.11.0 - #266
Merged
Merged
Conversation
enthus1ast/nimja#118 is fixed in nimja 0.11.0, which happyx now pulls in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014vxU9L8TCDMCxwvSH5LKR8
Owner
Author
|
Checked that the nimja fix is really released and that this PR's CI used it:
All checks are green, so this is ready to merge. Generated by Claude Code |
Makes the minimum nimja version explicit, so docsdeps never resolves to 0.10.4, which does not compile to js (enthus1ast/nimja#118). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YPMoamS3J47kGd4SUSKiTX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Pietro · project thread
Before:
nimble docsdepsinstalls nimja 0.10.3 and deletes the nimja 0.10.4 package directory, because 0.10.4 did not compile to js (enthus1ast/nimja#118). This was the workaround added in #261.After:
docsdepsis back to its original install line, and happyx pulls the latest nimja. nimja 0.11.0 (2026-10-29) fixes #118 by guardingcopyMemwithwhen defined(js) or defined(nimscript).How: revert the docsdeps part of #261 in
nimib.nimble. The ubuntu-24.04 pin from #261 stays.Generated by Claude Code