Repository navigation
Conversation
Member
|
Please write messages yourself, don’t copy paste garbage generated by an LLM. There’s a huge amount of noise in this PR. I don’t have time to sift through it.
|
Author
|
Updated comment |
Rajvira10
marked this pull request as ready for review
October 16, 2026 19:57
Member
|
I think CI failures are unrelated? |
WhyNotHugo
force-pushed
the
fix/weekday-header-padding
branch
from
October 20, 2026 03:12
0744c4d to
6b83dd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hungarian weekday headings contain padding spaces. Splitting on each space creates empty columns, which misaligns the headings. This changes split(" ") to split() so extra whitespace is ignored.
The tests cover Hungarian and English headings, both week starts, and week-number settings. All 17 calendar-widget tests pass. The full suite has one date-editor failure that also occurs on unchanged upstream.