Skip to content

fix: replace invalid example agent-type names in bundled skills (#607) - #3182

Draft
ruvnet wants to merge 2 commits into
mainfrom
triage/2026-09-05-issue-607
Draft

fix: replace invalid example agent-type names in bundled skills (#607)#3182
ruvnet wants to merge 2 commits into
mainfrom
triage/2026-09-05-issue-607

Conversation

@ruvnet

@ruvnet ruvnet commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes #607 ("analyst agent is never 'found'").

Several bundled .claude/skills/*.md files contain example Task(name, description, type) calls using generic placeholder type strings ("coordinator", "architect", "analyst", "specialist") that do not match any agent actually registered under .claude/agents/**/*.md. Claude Code's Task tool validates subagent_type against that live registry at runtime, so copying these examples verbatim fails with Agent type 'X' not found.

This replaces the 13 affected occurrences across 3 files with real registered agent names that match each example's context:

  • github-multi-repo/SKILL.md: coordinatormulti-repo-swarm / sync-coordinator, analystcode-analyzer, architectrepo-architect
  • hive-mind-advanced/SKILL.md: coordinatorqueen-coordinator
  • github-release-management/SKILL.md: coordinatorrelease-manager

Test coverage

Added v3/@claude-flow/cli/__tests__/skill-agent-types-607.test.ts — a narrow regression guard asserting the three affected files no longer contain the invalid placeholder Task(..., "coordinator"|"architect"|"analyst"|"specialist") pattern, and that they use the correct replacement agent names. Verified locally:

  • Fails (6/6) against the pre-fix file content (confirmed via git stash).
  • Passes (6/6) against the post-fix content.
  • Full @claude-flow/cli test suite run before/after shows no new failures (pre-existing unrelated failures are native-module/environment issues, e.g. @ruvector/ruvllm-wasm, not touched by this change).

Scope

Only the 3 SKILL.md files and one new test file are touched. No CI/workflow, release/publish tooling, or agent registry files were changed.


Opened by the nightly triage routine — human review required before merge.

🤖 Generated with RuFlo

https://claude.ai/code/session_013ck5ngNyhwAFzmN9PdaV4p


Generated by Claude Code

Several bundled .claude/skills/*.md files contain example Task(name,
description, type) calls using generic placeholder type strings
("coordinator", "architect", "analyst", "specialist") that do not match
any agent actually registered under .claude/agents/**/*.md. Claude
Code's Task tool validates subagent_type against that live registry at
runtime, so copying these examples verbatim fails with "Agent type 'X'
not found."

Replace the 13 affected occurrences across 3 files with real registered
agent names that match each example's context:
- github-multi-repo/SKILL.md: coordinator -> multi-repo-swarm/
  sync-coordinator, analyst -> code-analyzer, architect -> repo-architect
- hive-mind-advanced/SKILL.md: coordinator -> queen-coordinator
- github-release-management/SKILL.md: coordinator -> release-manager

Adds a narrow regression test asserting the three files no longer
contain the invalid placeholder pattern.

Fixes #607

Co-Authored-By: RuFlo <ruv@ruv.net>
Claude-Session: https://claude.ai/code/session_013ck5ngNyhwAFzmN9PdaV4p

ruvnet commented Sep 5, 2026

Copy link
Copy Markdown
Owner Author

CI status (2026-09-05, head e8e2f30)

CI is red, but not because of this PR's diff. Every failing job I checked (Test Suite (ubuntu-latest), Security & Code Quality, CVE Audit Gate / Audit root, plugin-registry signature verification smoke, and others across the matrix) dies at the same npm ci/npm install step with:

npm error code ETARGET
npm error notarget No matching version found for @claude-flow/mcp@3.0.0-alpha.10.

That pin already exists in package.json and v3/@claude-flow/cli/package.json at the base commit (db49919, introduced back in 2ec82b0) — this PR's diff touches only 3 .claude/skills/*.md files and one new test file, none of which reference @claude-flow/mcp or any manifest. This is a repo-wide dependency-resolution problem (the version isn't published/resolvable on the registry right now) that would break this same install step on essentially any open PR, including a clean rebase of main itself — it is not a regression introduced here.

I don't have a fix to port: this needs either publishing @claude-flow/mcp@3.0.0-alpha.10 or re-pinning it to a version that resolves, which is a release/dependency decision outside the scope of an unattended skills-doc fix. Not re-running the jobs — the error is deterministic (a real ETARGET, not a network flake), so a re-run won't change the outcome.

Once that pin is fixed repo-wide, this PR's own diff is trivial and should pass cleanly (it's docs + a narrow, verified regression test).


Generated by Claude Code

ruvnet commented Sep 5, 2026

Copy link
Copy Markdown
Owner Author

CI status update (2026-09-05, head 11583ec)

The repo-wide blocker is resolved: main's commit efadf92 ("fix(ci): add v3/@claude-flow/mcp to the root npm workspaces so npm ci resolves the unpublished alpha.10 pin (#3203)") fixed the @claude-flow/mcp@3.0.0-alpha.10 ETARGET failure I reported earlier. I merged main into this branch and pushed — all 109 CI checks are now green (success/skipped, zero failures), and the PR is mergeable (mergeable_state: clean).

This PR is a small, verified docs + regression-test fix (see original summary) and is ready for maintainer review/merge — I have not merged it myself per the nightly-triage invariants.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

analyst agent is never 'found'

2 participants