Skip to content

The Measurements PK doesn’t allow for finding data quickly - #260

Merged
smarr merged 2 commits into
masterfrom
fix-measurements-pk-order
Sep 22, 2026
Merged

smarr merged 2 commits into
masterfrom
fix-measurements-pk-order

Conversation

@smarr

@smarr smarr commented Sep 19, 2026

Copy link
Copy Markdown
Owner

The invocation is the least selective part of the PK. Putting runId and trialId first means we know exactly where our data is when looking for it, for instead when trying to look at the iteration data on the change view.

@smarr smarr added the enhancement New feature or request label Sep 19, 2026
The `invocation` is the least selective part of the PK.
Putting runId and trialId first means we know exactly where our data is when looking for it, for instead when trying to look at the iteration data on the change view.

Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
smarr force-pushed the fix-measurements-pk-order branch 2 times, most recently from 77e8181 to f99c5bc Compare September 22, 2026 20:23
@smarr

smarr commented Sep 22, 2026

Copy link
Copy Markdown
Owner Author

Also fixed this for ProfileData.
Benchmarks do not really show the difference. But that's more because they are noisy and not really measuring this specific use.
In production, this is a massive win. 40sec vs. 32ms to request the measurements on rebench.dev.

@smarr

smarr commented Sep 22, 2026

Copy link
Copy Markdown
Owner Author

@smarr
smarr merged commit 8343d2b into master Sep 22, 2026
2 checks passed
@smarr
smarr deleted the fix-measurements-pk-order branch September 22, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant