Skip to content

The Measurements PK doesn’t allow for finding data quickly #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smarr merged 2 commits into from
Sep 22, 2026
Merged

The Measurements PK doesn’t allow for finding data quickly #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
759b307
The Measurements PK doesn’t allow for finding data quickly
smarr Sep 19, 2026
f99c5bc
Fix PK order for ProfileData
smarr Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/backend/db/db.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ CREATE TABLE Measurement (

values float4[] NOT NULL,

primary key (invocation, runId, trialId, criterion),
primary key (runId, trialId, criterion, invocation),
foreign key (trialId) references Trial (id),
foreign key (runId) references Run (id),
foreign key (criterion) references Criterion (id)
Expand All @@ -171,7 +171,7 @@ CREATE TABLE ProfileData (

value text NOT NULL,

primary key (numIterations, invocation, runId, trialId),
primary key (runId, trialId, numIterations, invocation),
foreign key (trialId) references Trial (id),
foreign key (runId) references Run (id)
);
Expand Down
9 changes: 9 additions & 0 deletions src/backend/db/schema-updates/migration.015.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
-- The PK is wrongly ordered and makes queries for getting measurements very slow
-- because we end up scanning through all of the table.
ALTER TABLE Measurement
DROP CONSTRAINT measurement_pkey,
ADD CONSTRAINT measurement_pkey PRIMARY KEY (runid, trialid, criterion, invocation);

ALTER TABLE ProfileData
DROP CONSTRAINT profiledata_pkey,
ADD CONSTRAINT profiledata_pkey PRIMARY KEY (runid, trialid, numiterations, invocation);
Loading