Skip to content

[RL] Update RSL-RL to 5.5.1 - #7825

Merged
kellyguo11 merged 1 commit into
isaac-sim:developfrom
StafaH:update-rsl-rl-5.5.1
Sep 16, 2026
Merged

kellyguo11 merged 1 commit into
isaac-sim:developfrom
StafaH:update-rsl-rl-5.5.1

Conversation

@StafaH

@StafaH StafaH commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Description

Updates the rsl-rl-lib pin from 5.4.1 to 5.5.1 and removes the redundant direct onnxscript dependency, which RSL-RL already provides.

This is the dependency-only portion of #7784; no compatibility shims, tests, or runtime code are changed.

Type of change

  • Dependency update

Release backport

  • Backport this pull request to the active release branch after it merges into develop

Screenshots

Not applicable.

Validation

  • uv lock --check
  • uv run isaaclab -f
  • uv run python -m pytest source/isaaclab_rl/test/test_rsl_rl_cfg_deprecation.py -q (39 passed)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with uv run isaaclab -f
  • Documentation changes are not required for this dependency-only update
  • My changes generate no new warnings
  • Existing compatibility tests cover this dependency-only update
  • A changelog fragment is not required because no source package is changed
  • My name already exists in CONTRIBUTORS.md

@StafaH
StafaH requested a review from a team September 15, 2026 13:56
@StafaH
StafaH requested a review from kellyguo11 as a code owner September 15, 2026 13:56

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isaac Lab Review Bot

The dependency-only update consistently pins rsl-rl-lib 5.5.1 in the base dependencies and rsl-rl extra, with corresponding lockfile updates. The removed direct onnxscript declaration remains satisfied transitively by RSL-RL.

  • Design and architecture: Dependency ownership is simplified without introducing version skew: both RSL-RL declarations use 5.5.1, and onnxscript is delegated to the RSL-RL package that requires it. The lockfile confirms that dependency remains in the resolved graph.
  • API: No public Python API, CLI argument, or configuration field changes. Project metadata and the generated lockfile agree for the base and optional-extra dependency paths, and no source-package changelog or documentation update is required.
  • Implementation: The updated lock entry for rsl-rl-lib 5.5.1 retains onnxscript transitively. Although RSL-RL no longer brings in torchvision, the project continues to declare it directly. The remaining tradeoff is that the minimum supported onnxscript version is now controlled by RSL-RL rather than an Isaac Lab constraint.

No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.

Automated review; human maintainers own approval decisions.

@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The dependency update appears safe to merge, with no concrete compatibility, packaging, or security regression identified.

Summary

This PR updates the default and optional RSL-RL dependency pins from 5.4.1 to 5.5.1 and synchronizes the lockfile.

  • Removes redundant direct onnxscript declarations while retaining it transitively through RSL-RL.
  • Updates the locked RSL-RL artifacts and dependency metadata.
  • Keeps torchvision available through the root project’s existing direct dependency.

Reviews (1) · Last reviewed commit: "Update RSL-RL to 5.5.1"

@StafaH

StafaH commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator Author

run-ci

@isaaclab-bot isaaclab-bot Bot added ci:run-docker Trigger the on-demand Docker and GPU CI workflow and removed ci:run-docker Trigger the on-demand Docker and GPU CI workflow labels Sep 15, 2026
@kellyguo11
kellyguo11 merged commit 480398d into isaac-sim:develop Sep 16, 2026
112 of 116 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants