Build docs from the extra that provides Sphinx

[vidurv-nvidia]

Description

isaaclab -d (and ./isaaclab.sh -d) fails on develop:

$ ./isaaclab.sh -d
[INFO] Building documentation...
Installed 199 packages in 156ms
/home/.../bin/python: No module named sphinx
[ERROR] Command failed with code 1: "uv run --isolated --extra test -- python -m sphinx ..."

command_build_docs() in source/isaaclab/isaaclab/cli/commands/misc.py resolves its isolated environment from the test extra, but the Sphinx toolchain is declared in the dev extra (pyproject.toml: sphinx, sphinx-book-theme, sphinxcontrib-bibtex, sphinx-copybutton, sphinx-icon). test declares none of them.

This matters beyond the command itself: AGENTS.md instructs contributors to run ./isaaclab.sh -d after adding or changing public API symbols, so the documented workflow has been failing.

One-word fix: build from dev.

Type of change

• Bug fix (non-breaking change which fixes an issue)

Testing

Verified both directions on the same checkout, changing only this line:

state	result
clean develop	No module named sphinx, exit 1
with this change	build succeeds, docs/_build/current/index.html produced

Checklist

• I have read and understood the contribution guidelines
• I have run the pre-commit checks with ./isaaclab.sh --format
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• I have added a changelog fragment under source/<pkg>/changelog.d/ for every touched package
• I have added my name to the CONTRIBUTORS.md or my name already exists there

[isaaclab-review-bot]

Isaac Lab Review Bot

Updates the documentation build command to resolve its isolated environment from the existing dev extra that provides Sphinx, with a corresponding user-visible changelog fragment.

• Design and architecture: The change is confined to the documentation command’s dependency-resolution boundary and reuses the project’s existing dev extra rather than duplicating Sphinx dependencies elsewhere. The main tradeoff is resolving the broader development dependency set for documentation builds.
• API: The command names and arguments for isaaclab -d and ./isaaclab.sh -d remain unchanged. Their intended behavior is restored by making the required Sphinx toolchain available, and the change is documented in the package changelog fragment.
• Implementation: The updated --extra dev argument directly affects the isolated uv run invocation that launches python -m sphinx. The Sphinx options, documentation working directory, output path, and command execution path remain unchanged.

No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.

Automated review; human maintainers own approval decisions.

[greptile-apps]

Confidence Score: 4/5

The dependency fix itself is sound, but the PR should not merge until the existing CLI unit test is updated to accept the new dev argument.

Findings

1.  Docs command test now fails ▶

Summary

This PR fixes the isolated documentation build by selecting the root dev extra, which provides Sphinx and the configured documentation extensions.

• Changes command_build_docs() from the test-only dependency extra to the docs-capable development extra.
• Adds a changelog fragment explaining the corrected dependency selection.
• Leaves the directly related CLI unit test expecting the previous extra.

_{Reviews (1) · Last reviewed commit: "Build docs from the extra that provides ..."}

[greptile-apps]

Docs command test now fails

Changing this command to pass the dev extra leaves test_build_docs_runs_sphinx_with_the_uv_test_extra expecting --extra test. The targeted CLI test will fail until its expected command and name reflect the new docs environment.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[ooctipus]

run-ci

[ooctipus]

run-ci