Repository navigation
[Backport release/3.0.0] Harden CI dependencies, update Starlette, and align aiohttp - #7836
Conversation
|
run-ci |
|
|
run-ci |
There was a problem hiding this comment.
Isaac Lab Review Bot
The supply-chain hardening is coherent, but the Starlette dependency change removes an explicitly documented Isaac Sim 6.1 compatibility ceiling and now resolves a major-version jump without documenting or constraining compatibility.
- Design and architecture: The verified-download flow consistently restricts redirects to HTTPS and verifies checksums before destructive or executable steps. The CI contract-test environment is hash-locked and wheel-only, with the requirements file integrated into change detection.
- API: The aiohttp pin is synchronized between project metadata, the lockfile, and regression tests. However,
starlette>=1.3.1replaces the prior>=0.46.0,<0.50compatibility range, allowing the lockfile to select 1.6.0 while Isaac Sim 6.1 remains unchanged. Restore a verified upper bound or document why the broader range remains compatible. - Implementation: The cuRobo bootstrap correctly downloads and verifies the pinned script before removing pip or executing it, with cleanup and checksum-failure coverage. The contract-test requirements include the required pytest and YAML dependency closure and are checked with
uv pip check.
Minor fixes needed. Posted 1 actionable finding inline.
Automated review; human maintainers own approval decisions.
| "pillow>=12.3.0", | ||
| "botocore", # omni.replicator.core S3 backend | ||
| "starlette>=0.46.0,<0.50", # livestream; range coexists with isaacsim 6.1 | ||
| "starlette>=1.3.1", # livestream; minimum patched for current security advisories |
There was a problem hiding this comment.
🟡 Warning · Api — Starlette Isaac Sim compatibility ceiling removed
The replaced specifier >=0.46.0,<0.50 carried an explicit note that the range must coexist with Isaac Sim 6.1's livestream stack. The new >=1.3.1 removes the ceiling entirely and the lock now resolves 1.6.0, a major-version jump beyond the stated security floor, while isaacsim[all,extscache]==6.1.0.0 is unchanged and aiohttp in the same patch was pinned exactly for kernel alignment. Retain a verified upper bound or record why coexistence still holds.
|
run-ci |
Description
Backports the security and supply-chain hardening to
release/3.0.0.get-pip.pybootstrap>=1.3.1==3.14.1to matchisaacsim-kernel==6.1.0.0Develop PR: #7835
Type of change
Release backport
release/3.0.0Screenshots
Not applicable.
Validation
uv lock --checkpassedget-pip.pydigestChecklist
CONTRIBUTORS.md